Doccommentdata node (Document Commenting Plugin) categorization

Experience Manager (PaaS/OnPrem)
1

Hello community,

We are migrating from Hippo 11 to 12 and have used the Document Commenting Plugin for quite some time. The doccommentdata node’s children seem to contain the current comments. As far as I can tell, the latest (3.0.0) version of the plug-in does not explicitly categorize child-nodes (through .meta:residual-child-node-category) so they default to config. This results in the doccommentdata being wiped out (as the Configuration Verifier correctly detects).

My question: Is this intended behavior? If not, should the child nodes be categorized as content or system?

Kind regards,
Davey Chu

2

Hi Davey,

I think you’re right. Would you provide a pull request against the develop branch [1]? Then we’ll do the next step soon.

Woonsan

[1] GitHub - bloomreach-forge/document-commenting: Add commenting functionality for content editors in the CMS

3

Hi Woonsan,

I have made a pull request that categorizes the child nodes as content. If they are better categorized as system, I’ll gladly change it. For my own understanding, I would appreciate it if you could explain your reasoning for one or the other category.

Kind regards,
Davey Chu

4

Hey Davey,

Thanks again! You’re totally right. Would you change it to “system”? Then I will merge it and cut a new release very soon.

The /doccommentdata node is the comment data storage folder, similarly to HST Form Data storage [2,3]. And HST also sets it to “system”. [4]

Woonsan

[2] https://www.onehippo.org/library/concepts/component-development/hst-2-forms.html
[3] https://www.onehippo.org/library/administration/maintenance/form-data-cleanup.html
[4] https://code.onehippo.org/cms-community/hippo-site-toolkit/blob/hst-5.4.0/toolkit-resources/addon/repository/src/main/resources/hcm-config/formdata.yaml#L4

5

Hi Woonsan,

I updated the pull request. Thanks for the extra explanation.

Kind regards,
Davey Chu

6

Thanks again for your contribution, Davey!
I’ve cut a new release, v3.0.1:

Cheers,

Woonsan